Source/core/rendering/RenderText.h - Issue 351213002: Change RenderObject::style(bool) to accept an enum instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderText.h

Issue 351213002: Change RenderObject::style(bool) to accept an enum instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed enum to OwnOrFirstLineStyle, rebased and got rid of duplicate state on the stack in RootInl… Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderText.h

diff --git a/Source/core/rendering/RenderText.h b/Source/core/rendering/RenderText.h

index 1f3de61ca1834ebc4b7472470aa38e86075f80b3..03b3790b60303fce069e54ce09bcb0d8cc100885 100644

--- a/Source/core/rendering/RenderText.h

+++ b/Source/core/rendering/RenderText.h

@@ -85,7 +85,7 @@ public:

void positionLineBox(InlineBox*);

virtual float width(unsigned from, unsigned len, const Font&, float xPos, TextDirection, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

- virtual float width(unsigned from, unsigned len, float xPos, TextDirection, bool firstLine = false, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

+ virtual float width(unsigned from, unsigned len, float xPos, TextDirection, OwnOrFirstLineStyle = OwnStyle, HashSet<const SimpleFontData*>* fallbackFonts = 0, GlyphOverflow* = 0) const;

float minLogicalWidth() const;

float maxLogicalWidth() const;

« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »