Source/core/rendering/RenderMenuList.h - Issue 351213002: Change RenderObject::style(bool) to accept an enum instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMenuList.h

Issue 351213002: Change RenderObject::style(bool) to accept an enum instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed enum to OwnOrFirstLineStyle, rebased and got rid of duplicate state on the stack in RootInl… Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMenuList.h

diff --git a/Source/core/rendering/RenderMenuList.h b/Source/core/rendering/RenderMenuList.h

index b7dc98c965b7a57a24076aa16c0952ba1caeee4e..76200f131448376c651db9e48231e12c1c67a58d 100644

--- a/Source/core/rendering/RenderMenuList.h

+++ b/Source/core/rendering/RenderMenuList.h

@@ -100,7 +100,7 @@ private:

// Flexbox defines baselines differently than regular blocks.

// For backwards compatibility, menulists need to do the regular block behavior.

- virtual int baselinePosition(FontBaseline baseline, bool firstLine, LineDirectionMode direction, LinePositionMode position) const OVERRIDE

+ virtual int baselinePosition(FontBaseline baseline, OwnOrFirstLineStyle firstLine, LineDirectionMode direction, LinePositionMode position) const OVERRIDE

{

return RenderBlock::baselinePosition(baseline, firstLine, direction, position);

}

« no previous file with comments | « Source/core/rendering/RenderListMarker.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »