Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/core/rendering/RenderBR.cpp

Issue 351213002: Change RenderObject::style(bool) to accept an enum instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Renamed enum to OwnOrFirstLineStyle, rebased and got rid of duplicate state on the stack in RootInl… Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderBR.h ('k') | Source/core/rendering/RenderBlock.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 26 matching lines...) Expand all
37 37
38 RenderBR::RenderBR(Node* node) 38 RenderBR::RenderBR(Node* node)
39 : RenderText(node, newlineString()) 39 : RenderText(node, newlineString())
40 { 40 {
41 } 41 }
42 42
43 RenderBR::~RenderBR() 43 RenderBR::~RenderBR()
44 { 44 {
45 } 45 }
46 46
47 int RenderBR::lineHeight(bool firstLine) const 47 int RenderBR::lineHeight(OwnOrFirstLineStyle firstLine) const
48 { 48 {
49 RenderStyle* s = style(firstLine && document().styleEngine()->usesFirstLineR ules()); 49 RenderStyle* s = style(firstLine && document().styleEngine()->usesFirstLineR ules() ? FirstLineStyle : OwnStyle);
50 return s->computedLineHeight(); 50 return s->computedLineHeight();
51 } 51 }
52 52
53 void RenderBR::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle) 53 void RenderBR::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
54 { 54 {
55 RenderText::styleDidChange(diff, oldStyle); 55 RenderText::styleDidChange(diff, oldStyle);
56 } 56 }
57 57
58 int RenderBR::caretMinOffset() const 58 int RenderBR::caretMinOffset() const
59 { 59 {
60 return 0; 60 return 0;
61 } 61 }
62 62
63 int RenderBR::caretMaxOffset() const 63 int RenderBR::caretMaxOffset() const
64 { 64 {
65 return 1; 65 return 1;
66 } 66 }
67 67
68 PositionWithAffinity RenderBR::positionForPoint(const LayoutPoint&) 68 PositionWithAffinity RenderBR::positionForPoint(const LayoutPoint&)
69 { 69 {
70 return createPositionWithAffinity(0, DOWNSTREAM); 70 return createPositionWithAffinity(0, DOWNSTREAM);
71 } 71 }
72 72
73 } // namespace WebCore 73 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBR.h ('k') | Source/core/rendering/RenderBlock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698