Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 351183003: [Android] Add heap_profiler_unittests to Android bots. (Closed)

Created:
6 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
bulach, navabi, navabi1
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@libheap_profiler
Project:
chromium
Visibility:
Public.

Description

[Android] Add heap_profiler_unittests to Android bots. Add proper coverage to heap_profiler. BUG=382489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282626

Patch Set 1 #

Patch Set 2 : Depend on _stripped target for unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Primiano Tucci (use gerrit)
bulach could you PTAL to this mini CL? I'm making this in another CL, so ...
6 years, 6 months ago (2014-06-26 11:54:50 UTC) #1
bulach
lgtm but navabi is the right owner..
6 years, 6 months ago (2014-06-26 14:36:26 UTC) #2
navabi
lgtm
6 years, 6 months ago (2014-06-26 17:45:08 UTC) #3
navabi1
lgtm
6 years, 6 months ago (2014-06-26 17:45:16 UTC) #4
Primiano Tucci (use gerrit)
On 2014/06/26 17:45:08, navabi wrote: On 2014/06/26 17:45:16, navabi1 wrote: Should I wait also for ...
6 years, 6 months ago (2014-06-26 18:02:51 UTC) #5
navabi
On 2014/06/26 18:02:51, Primiano Tucci wrote: > On 2014/06/26 17:45:08, navabi wrote: > On 2014/06/26 ...
6 years, 6 months ago (2014-06-26 22:17:01 UTC) #6
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 10:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/351183003/1
6 years, 5 months ago (2014-07-11 10:57:08 UTC) #8
Primiano Tucci (use gerrit)
The CQ bit was unchecked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 12:20:35 UTC) #9
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-11 12:25:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/351183003/20001
6 years, 5 months ago (2014-07-11 12:25:47 UTC) #11
commit-bot: I haz the power
Change committed as 282626
6 years, 5 months ago (2014-07-11 14:18:43 UTC) #12
Primiano Tucci (use gerrit)
6 years, 5 months ago (2014-07-11 18:45:30 UTC) #13
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/386073002/ by primiano@chromium.org.

The reason for reverting is: It seems to be breaking some internal bots. :-/
.

Powered by Google App Engine
This is Rietveld 408576698