Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 351163002: Prevent sandboxed iframes from bypassing WebSocket mixed content checks. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Prevent sandboxed iframes from bypassing WebSocket mixed content checks. This patch ensures that we check both the current context and the top-level browsing context when evaluating whether or not an insecure websocket connection should be blocked as mixed content. BUG=389040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177070

Patch Set 1 #

Patch Set 2 : Test. #

Messages

Total messages: 5 (0 generated)
Mike West
Takeshi-san, would you mind taking a look at this patch? -mike
6 years, 6 months ago (2014-06-26 08:47:20 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-27 01:30:23 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-27 04:44:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/351163002/20001
6 years, 6 months ago (2014-06-27 04:45:06 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 05:56:42 UTC) #5
Message was sent while issue was closed.
Change committed as 177070

Powered by Google App Engine
This is Rietveld 408576698