Issue 351133003: Cleanup usage of GetResourcePath() after commit bcbc1788b478b1e54079318ad073e8490aa66fae.

Issue 351133003: Cleanup usage of GetResourcePath() after commit bcbc1788b478b1e54079318ad073e8490aa66fae. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Cleanup usage of GetResourcePath() after commit bcbc1788b478b1e54079318ad073e8490aa66fae. There was a clean up opportunity left over after https://skia.googlesource.com/skia/+/bcbc1788b478b1e54079318ad073e8490aa66fae, that could make use of the default parameter of GetResourcePath() function to make some call sites cleaner. We decided to make it in a separate CL to make reviewer's and author's life easier, so we could catch errors and/or mistakes easily. BUG=None TEST=make all && out/Debug/dm && out/Debug/SampleApp R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/c846f4a96bcde1ffeaf17afc1469db6f2cbd1ad3

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -62 lines)			Patch
M	bench/ETCBitmapBench.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	gm/cmykjpeg.cpp	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	gm/coloremoji.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	gm/copyTo4444.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	gm/downsamplebitmap.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	gm/etc1bitmap.cpp	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	gm/factory.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	gm/filterbitmap.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	gm/filterindiabox.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	samplecode/SamplePicture.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	samplecode/SampleSubpixelTranslate.cpp	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/ImageDecodingTest.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	tests/KtxTest.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/351133003/130001

6 years, 5 months ago (2014-07-01 19:21:41 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-01 19:35:54 UTC) #5

Message was sent while issue was closed.

Change committed as c846f4a96bcde1ffeaf17afc1469db6f2cbd1ad3