Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 351133002: Adds an internal server and chromium's flag for disabling/enabling FEC (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Jana, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana, dmz
Project:
chromium
Visibility:
Public.

Description

Adds an internal server and chromium's flag for disabling/enabling FEC protection, and control of FEC policy using client-specified tags. Internal server's flag can be used for enabling/disabling FEC protection. For FEC protection to be used, client has to request protection through the config in the CHLO. Only one tag is currently specified (kHDR, which maps to FEC protection for the headers and crypto streams), but the plan is to introduce at least one more tag soon (kHED, which will map to FEC protection for the headers and crypto streams and also the heads of all other streams.). These tags map to overall FEC configs, and the plan is to try out configs via finch. Disabled FLAGS_enable_quic_fec flag in chromium. Will enable in a separate CL after talking with jri. Merge internal change: 69898759 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -37 lines) Patch
M net/quic/crypto/crypto_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_client_session_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_client_session_base.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M net/quic/quic_config.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_config.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M net/quic/quic_config_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +11 lines, -19 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_server_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_server_session.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +44 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +24 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-26 03:10:43 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-26 15:47:40 UTC) #2
Jana
6 years, 6 months ago (2014-06-26 16:29:37 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698