Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 351053002: Add valgrind supp for NV driver. (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove extra \n #

Total comments: 2

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind.supp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 6 months ago (2014-06-25 13:22:42 UTC) #1
mtklein
lgtm https://codereview.chromium.org/351053002/diff/20001/tools/valgrind.supp File tools/valgrind.supp (right): https://codereview.chromium.org/351053002/diff/20001/tools/valgrind.supp#newcode75 tools/valgrind.supp:75: obj:/usr/lib/libnvidia-glcore.so* I think nv_driver_bug_4 now subsumes nv_driver_bug_2. Merge?
6 years, 6 months ago (2014-06-25 13:28:02 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-06-25 15:09:02 UTC) #3
bsalomon
https://codereview.chromium.org/351053002/diff/20001/tools/valgrind.supp File tools/valgrind.supp (right): https://codereview.chromium.org/351053002/diff/20001/tools/valgrind.supp#newcode75 tools/valgrind.supp:75: obj:/usr/lib/libnvidia-glcore.so* On 2014/06/25 13:28:02, mtklein wrote: > I think ...
6 years, 6 months ago (2014-06-25 15:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/351053002/40001
6 years, 6 months ago (2014-06-25 15:10:08 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 15:25:36 UTC) #6
Message was sent while issue was closed.
Change committed as 61d04c4bf094053d9daceb2915e7e3ed066747eb

Powered by Google App Engine
This is Rietveld 408576698