Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 351003003: DevTools: Added properties to ScreencastFrameMetadata (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Added properties to ScreencastFrameMetadata BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177017

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added new properties #

Total comments: 4

Patch Set 3 : Better description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/devtools/protocol.json View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-25 11:51:22 UTC) #1
pfeldman
https://codereview.chromium.org/351003003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/351003003/diff/1/Source/devtools/protocol.json#newcode204 Source/devtools/protocol.json:204: { "name": "device", "$ref": "DOM.Rect", "hidden": true, "description": "Device ...
6 years, 6 months ago (2014-06-25 13:20:49 UTC) #2
dgozman
I'd say we need only the following: For image: viewSize topControlsHeight/bottomControlsHeight For highlight: scrollOffset pageScaleFactor
6 years, 6 months ago (2014-06-25 13:27:09 UTC) #3
dgozman
lgtm https://codereview.chromium.org/351003003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/351003003/diff/20001/Source/devtools/protocol.json#newcode206 Source/devtools/protocol.json:206: { "name": "scrollOffsetX", "type": "number", "hidden": true, "description": ...
6 years, 6 months ago (2014-06-26 11:35:47 UTC) #4
vkuzkokov
https://codereview.chromium.org/351003003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/351003003/diff/20001/Source/devtools/protocol.json#newcode206 Source/devtools/protocol.json:206: { "name": "scrollOffsetX", "type": "number", "hidden": true, "description": "Position ...
6 years, 6 months ago (2014-06-26 12:11:26 UTC) #5
pfeldman
lgtm
6 years, 6 months ago (2014-06-26 12:27:24 UTC) #6
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-26 12:29:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/351003003/40001
6 years, 6 months ago (2014-06-26 12:29:48 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 19:24:28 UTC) #9
Message was sent while issue was closed. 
Change committed as 177017

Powered by Google App Engine
This is Rietveld 408576698