Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 350993002: Remove an unused argument from SpellChecker::spellCheckOldSelection. (Closed)

Created:
6 years, 6 months ago by yoichio
Modified:
6 years, 5 months ago
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove an unused argument from SpellChecker::spellCheckOldSelection. I'm not sure since when, anyway |newSelectedSentence| is no longer used. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/editing/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoichio
6 years, 6 months ago (2014-06-25 08:58:22 UTC) #1
yosin_UTC9
LGTM +tkent@, since yutak@ is OOO til Jun 30. Could you take look? Thanks in ...
6 years, 6 months ago (2014-06-26 01:39:40 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-26 01:50:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/350993002/1
6 years, 6 months ago (2014-06-26 01:51:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 07:52:42 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-06-27 07:52:43 UTC) #6
yoichio
The CQ bit was checked by yoichio@chromium.org
6 years, 5 months ago (2014-06-27 07:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/350993002/1
6 years, 5 months ago (2014-06-27 07:54:10 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 08:25:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 177080

Powered by Google App Engine
This is Rietveld 408576698