Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 350973003: Killing off quic V17. Not flag protected. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 21351fe930eb4587cb88f86eba18dfbfcffa6dd9..fc646deb431c0d2a66d1fe6fbcbd0f28f38b6763 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -117,7 +117,7 @@ vector<TestParams> GetTestParams() {
for (size_t i = 1; i < all_supported_versions.size(); ++i) {
QuicVersionVector server_supported_versions;
server_supported_versions.push_back(all_supported_versions[i]);
- if (all_supported_versions[i] >= QUIC_VERSION_17) {
+ if (all_supported_versions[i] >= QUIC_VERSION_18) {
// Until flow control is globally rolled out and we remove
// QUIC_VERSION_16, the server MUST support at least one QUIC version
// that does not use flow control.
@@ -633,11 +633,11 @@ TEST_P(EndToEndTest, DISABLED_LargePostZeroRTTFailure) {
// The 0-RTT handshake should succeed.
client_->Connect();
- if (client_supported_versions_[0] >= QUIC_VERSION_17 &&
- negotiated_version_ < QUIC_VERSION_17) {
+ if (client_supported_versions_[0] >= QUIC_VERSION_18 &&
+ negotiated_version_ <= QUIC_VERSION_16) {
// If the version negotiation has resulted in a downgrade, then the client
// must wait for the handshake to complete before sending any data.
- // Otherwise it may have queued QUIC_VERSION_17 frames which will trigger a
+ // Otherwise it may have queued frames which will trigger a
// DFATAL when they are serialized after the downgrade.
client_->client()->WaitForCryptoHandshakeConfirmed();
}
@@ -654,11 +654,11 @@ TEST_P(EndToEndTest, DISABLED_LargePostZeroRTTFailure) {
StartServer();
client_->Connect();
- if (client_supported_versions_[0] >= QUIC_VERSION_17 &&
- negotiated_version_ < QUIC_VERSION_17) {
+ if (client_supported_versions_[0] >= QUIC_VERSION_18 &&
+ negotiated_version_ <= QUIC_VERSION_16) {
// If the version negotiation has resulted in a downgrade, then the client
// must wait for the handshake to complete before sending any data.
- // Otherwise it may have queued QUIC_VERSION_17 frames which will trigger a
+ // Otherwise it may have queued frames which will trigger a
// DFATAL when they are serialized after the downgrade.
client_->client()->WaitForCryptoHandshakeConfirmed();
}
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698