chrome/browser/extensions/api/commands/command_service.cc - Issue 350943003: Support global keyboard commands on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 350943003: Support global keyboard commands on Chrome OS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address various comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/commands/command_service.cc

diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc

index 74d3b6a66ee0bb464a4d35644f22ee213378ba6a..3656f4b98830ca5dbfcde76a2b77127600157e38 100644

--- a/chrome/browser/extensions/api/commands/command_service.cc

+++ b/chrome/browser/extensions/api/commands/command_service.cc

@@ -361,8 +361,7 @@ Command CommandService::FindCommandByName(const std::string& extension_id,

if (!IsForCurrentPlatform(shortcut))

continue;

bool global = false;

- if (FeatureSwitch::global_commands()->IsEnabled())

- item->GetBoolean(kGlobal, &global);

+ item->GetBoolean(kGlobal, &global);

std::vector<std::string> tokens;

base::SplitString(shortcut, ':', &tokens);