Support global keyboard commands on Chrome OS.

chrome/browser/extensions/extension_commands_global_registry_apitest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "content/public/test/browser_test_utils.h"
@@ skipping 93 matching lines @@
   CGEventPost(event_tap_location, shift_down);
   CGEventPost(event_tap_location, key_down);
   CGEventPost(event_tap_location, key_up);
   CGEventPost(event_tap_location, shift_up);
   CGEventPost(event_tap_location, command_up);
 
   CFRelease(event_source);
 }
 #endif
 
-#if defined(OS_CHROMEOS)
-// Fully implemented everywhere except Chrome OS.
-#define MAYBE_GlobalCommand DISABLED_GlobalCommand
-#else
-#define MAYBE_GlobalCommand GlobalCommand
-#endif
-
 // Test the basics of global commands and make sure they work when Chrome
 // doesn't have focus. Also test that non-global commands are not treated as
 // global and that keys beyond Ctrl+Shift+[0..9] cannot be auto-assigned by an
 // extension.
-IN_PROC_BROWSER_TEST_F(GlobalCommandsApiTest, MAYBE_GlobalCommand) {
-  FeatureSwitch::ScopedOverride enable_global_commands(
-      FeatureSwitch::global_commands(), true);
-
+IN_PROC_BROWSER_TEST_F(GlobalCommandsApiTest, GlobalCommand) {
   // Load the extension in the non-incognito browser.
   ResultCatcher catcher;
   ASSERT_TRUE(RunExtensionTest("keybinding/global")) << message_;
   ASSERT_TRUE(catcher.GetNextResult());
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_CHROMEOS)

[Finnur, 2014/06/27 11:10:57]

Yay! I was hoping something like this would do the trick!

[dtseng, 2014/07/07 18:17:19]

Sorry for the late update on this (just back from OOO).

This test works fine since it registers ctrl+shift+1. The other test, though,
times out because it attempts to register media keys (which are taken by ash).
In effort to get this cl in, I've omitted Chrome OS from that test.

In forced app mode, on ash at least, overriding of media keys appears to be
allowed, but this is not the case in general.

   // Our infrastructure for sending keys expects a browser to send them to, but
   // to properly test global shortcuts you need to send them to another target.
   // So, create an incognito browser to use as a target to send the shortcuts
   // to. It will ignore all of them and allow us test whether the global
   // shortcut really is global in nature and also that the non-global shortcut
   // is non-global.
   Browser* incognito_browser = CreateIncognitoBrowser();
 
   // Try to activate the non-global shortcut (Ctrl+Shift+1) and the
   // non-assignable shortcut (Ctrl+Shift+A) by sending the keystrokes to the
@@ skipping 28 matching lines @@
   SendNativeCommandShift(kVK_ANSI_A);
   SendNativeCommandShift(kVK_ANSI_9);
 #endif
 
   // If this fails, it might be because the global shortcut failed to work,
   // but it might also be because the non-global shortcuts unexpectedly
   // worked.
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 #if defined(OS_WIN)

[Finnur, 2014/06/27 11:10:57]

What was the outcome of the experiment to run this on all platforms?

[David Tseng, 2014/06/28 14:17:50]

It does pass; I'll enable the test for Chrome OS as well. The comment made it
seem like there's explicit action required of other platforms? (e.g. what about
linux or is it just the test not sending keys through X).

[Finnur, 2014/06/30 10:39:44]

Yeah, when I wrote that comment, the other platforms weren't ready and then
other people implemented a solution for Linux and Mac (but didn't enable the
test). I was somewhat confident that Linux would work, but less sure about Mac.
Glad to hear they all work.

Can you enable this test for all platforms then? (that pass)

 // The feature is only fully implemented on Windows, other platforms coming.
 // TODO(smus): On mac, SendKeyPress must first support media keys.
 #define MAYBE_GlobalDuplicatedMediaKey GlobalDuplicatedMediaKey
 #else
 #define MAYBE_GlobalDuplicatedMediaKey DISABLED_GlobalDuplicatedMediaKey
 #endif
 
 IN_PROC_BROWSER_TEST_F(GlobalCommandsApiTest, MAYBE_GlobalDuplicatedMediaKey) {
-  FeatureSwitch::ScopedOverride enable_global_commands(
-      FeatureSwitch::global_commands(), true);
-
   ResultCatcher catcher;
   ASSERT_TRUE(RunExtensionTest("keybinding/global_media_keys_0")) << message_;
   ASSERT_TRUE(catcher.GetNextResult());
   ASSERT_TRUE(RunExtensionTest("keybinding/global_media_keys_1")) << message_;
   ASSERT_TRUE(catcher.GetNextResult());
 
   Browser* incognito_browser = CreateIncognitoBrowser();  // Ditto.
   WindowController* controller =
       incognito_browser->extension_window_controller();
 
   ui_controls::SendKeyPress(controller->window()->GetNativeWindow(),
                             ui::VKEY_MEDIA_NEXT_TRACK,
                             false,
                             false,
                             false,
                             false);
 
   // We should get two success result.
   ASSERT_TRUE(catcher.GetNextResult());
   ASSERT_TRUE(catcher.GetNextResult());
 }
 
 }  // namespace extensions