Refactor llvm2ice so that Ice can be built while reading bitcode.

src/IceConverter.h

+//===- subzero/src/IceConverter.h - Converts LLVM to Ice  ------*- C++ -*-===//

[Jim Stichnoth, 2014/06/24 23:06:37]

Space this out to 80 chars like the other similar lines. :)
Also, ICE not Ice.

[Karl, 2014/06/25 16:02:05]

Done.

+//
+//                        The Subzero Code Generator
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file declares the LLVM to ICE converter.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef SUBZERO_SRC_ICECONVERTER_H
+#define SUBZERO_SRC_ICECONVERTER_H
+
+#include "IceGlobalContext.h"
+
+namespace llvm {

[Jim Stichnoth, 2014/06/24 23:06:37]

Does this need to be inside the llvm namespace?  I wouldn't expect it to be in
any namespace.

Maybe you wanted "using namespace llvm;" ?

[Karl, 2014/06/25 16:02:05]

First off, it is a bad idea to use "using namespace llvm" in a header file. This
class should be put into some namespace, so that it doesn't conflict with other
usages. I used "llvm" not knowing what space to put it in. I assume that it
shouldn't be in "Ice" either. Changing it to "Llvm2Ice", and removing
corresponding prefix on class name.

[Jim Stichnoth, 2014/06/26 23:50:12]

Yeah, you're right about "using namespace" and header files.

I would just use the Ice namespace, especially since this is a subzero/src/Ice*
file.

[Karl, 2014/06/27 16:15:21]

Done.

+
+class Module;
+
+class LLVM2ICEConverterDriver {
+public:
+  LLVM2ICEConverterDriver(Ice::GlobalContext *Ctx,
+                          bool DisableInternal,
+                          bool SubzeroTimingEnabled,
+                          bool DisableTranslation)
+      : Ctx(Ctx),
+        DisableInternal(DisableInternal),
+        SubzeroTimingEnabled(SubzeroTimingEnabled),
+        DisableTranslation(DisableTranslation)
+  {}
+  /// Converts the LLVM Module to ICE. Returns exit status 0 if successful,
+  /// Nonzero otherwise.
+  int convertToIce(Module *Mod);
+private:
+  Ice::GlobalContext *Ctx;
+  bool DisableInternal;
+  bool SubzeroTimingEnabled;
+  bool DisableTranslation;
+};
+
+}
+
+#endif  // SUBZERO_SRC_ICECONVERTER_H