Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 350923005: Defer marking libraries as ‘loaded’ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 37822)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -4748,14 +4748,9 @@
const Error& error = Error::Handle(isolate, Compiler::Compile(lib, script));
if (error.IsNull()) {
*result = Api::NewHandle(isolate, lib.raw());
- if (update_lib_status) {
- lib.SetLoaded();
- }
} else {
*result = Api::NewHandle(isolate, error.raw());
- if (update_lib_status) {
- lib.SetLoadError();
- }
+ lib.SetLoadError();
}
}
@@ -5151,6 +5146,11 @@
DARTSCOPE(isolate);
CHECK_CALLBACK_STATE(isolate);
+ isolate->DoneLoading();
+
+ // TODO(hausner): move the remaining code below (finalization and
+ // invoing of _completeDeferredLoads) into Isolate::DoneLoading().
+
// Finalize all classes if needed.
Dart_Handle state = Api::CheckIsolateState(isolate);
if (::Dart_IsError(state)) {
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698