Defer marking libraries as ‘loaded’

runtime/vm/dart_api_impl.cc

Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc	(revision 37661)
+++ runtime/vm/dart_api_impl.cc	(working copy)
@@ -4748,14 +4748,9 @@
   const Error& error = Error::Handle(isolate, Compiler::Compile(lib, script));
   if (error.IsNull()) {
     *result = Api::NewHandle(isolate, lib.raw());
-    if (update_lib_status) {
-      lib.SetLoaded();
-    }
   } else {
     *result = Api::NewHandle(isolate, error.raw());
-    if (update_lib_status) {
-      lib.SetLoadError();
-    }
+    lib.SetLoadError();
   }
 }
 
@@ -5151,6 +5146,8 @@
   DARTSCOPE(isolate);
   CHECK_CALLBACK_STATE(isolate);
 
+  isolate->DoneLoading();

[Ivan Posva, 2014/06/26 08:37:46]

We should consider moving all of the code below into DoneLoading() or is there
any reason to call Isolate::DoneLoading() without triggering class finalization
and the completion of deferred loads?

Different CL.

[hausner, 2014/06/30 17:18:43]

Added a TODO.

+
   // Finalize all classes if needed.
   Dart_Handle state = Api::CheckIsolateState(isolate);
   if (::Dart_IsError(state)) {