Issue 350913004: Let test driver nuke test perf data on errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350913004: Let test driver nuke test perf data on errors. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Let test driver nuke test perf data on errors. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22055

Patch Set 2 : Review #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
	M	tools/testrunner/local/execution.py	View	1	4 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment https://codereview.chromium.org/350913004/diff/1/tools/testrunner/local/execution.py File tools/testrunner/local/execution.py (right): https://codereview.chromium.org/350913004/diff/1/tools/testrunner/local/execution.py#newcode144 tools/testrunner/local/execution.py:144: self._RunPerfSafe(lambda: self.perfdata.UpdatePerfData(test)) One more suggestion: move ...

6 years, 5 months ago (2014-06-27 09:46:34 UTC) #2

Michael Achenbach

6 years, 5 months ago (2014-06-27 09:51:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22055 (presubmit successful).

Expand Messages | Collapse Messages

Issue 350913004: Let test driver nuke test perf data on errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review #

Messages