Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 350903003: Revert of Add VideoFrameRecorder for use recording test frame sequences. (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add VideoFrameRecorder for use recording test frame sequences. (https://codereview.chromium.org/339073002/) Reason for revert: Brand new test fails in ASAN: Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x462ccb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x7ee8f9 in CreateNextFrame remoting/host/video_frame_recorder_unittest.cc:96 #2 0x7ee8f9 in remoting::VideoFrameRecorderTest::CreateTestFrames() remoting/host/video_frame_recorder_unittest.cc:112 #3 0x7f1184 in remoting::VideoFrameRecorderTest_EncodeButDontRecord_Test::TestBody() remoting/host/video_frame_recorder_unittest.cc:269 #4 0xb3bf38 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb3bf38 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb3e1c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb3ef56 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb5206a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb516a0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb516a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xab66bc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xab66bc in base::TestSuite::Run() base/test/test_suite.cc:227 #13 0xaada32 in Run base/callback.h:401 #14 0xaada32 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #15 0xaad3ad in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553 #16 0x4e8067 in main chrome/test/base/run_all_remoting_unittests.cc:31 #17 0x7f1f660df76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add VideoFrameRecorder for use recording test frame sequences. > > This will be used to record representative frame sequences for performance evaluation of the new VP9 encoder. > > BUG=260879 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279795 TBR=sergeyu@chromium.org,wez@chromium.org NOTREECHECKS=true NOTRY=true BUG=260879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -589 lines) Patch
D remoting/host/video_frame_recorder.h View 1 chunk +0 lines, -100 lines 0 comments Download
D remoting/host/video_frame_recorder.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D remoting/host/video_frame_recorder_unittest.cc View 1 chunk +0 lines, -279 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
Created Revert of Add VideoFrameRecorder for use recording test frame sequences.
6 years, 6 months ago (2014-06-25 20:41:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/350903003/1
6 years, 6 months ago (2014-06-25 20:42:46 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 20:44:22 UTC) #3
Message was sent while issue was closed.
Change committed as 279805

Powered by Google App Engine
This is Rietveld 408576698