Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 350863002: Replaced ToV8Value::toV8Value with V8ValueTraits::toV8Value. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-wtf_chromium.org, Mikhail, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Replaced ToV8Value::toV8Value with V8ValueTraits::toV8Value. BUG=369451 TEST=no new tests because of just refactoring. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177060

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Reverted Source/wtf change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -85 lines) Patch
M Source/bindings/v8/ScriptPromise.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptPromiseResolver.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 2 chunks +44 lines, -83 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-24 08:26:00 UTC) #1
yhirano
https://codereview.chromium.org/350863002/diff/20001/Source/bindings/v8/V8Binding.h File Source/bindings/v8/V8Binding.h (right): https://codereview.chromium.org/350863002/diff/20001/Source/bindings/v8/V8Binding.h#newcode240 Source/bindings/v8/V8Binding.h:240: typedef typename WTF::RemovePointer<T>::Type TypeWithoutPointer; [optional] You can use WTF::getPtr ...
6 years, 6 months ago (2014-06-24 09:24:09 UTC) #2
tasak
Thank you for reviewing. https://codereview.chromium.org/350863002/diff/20001/Source/bindings/v8/V8Binding.h File Source/bindings/v8/V8Binding.h (right): https://codereview.chromium.org/350863002/diff/20001/Source/bindings/v8/V8Binding.h#newcode240 Source/bindings/v8/V8Binding.h:240: typedef typename WTF::RemovePointer<T>::Type TypeWithoutPointer; On ...
6 years, 6 months ago (2014-06-26 05:04:02 UTC) #3
tasak
jochen, would you review this CL? I need Source/wtf owner's LGTM.
6 years, 6 months ago (2014-06-26 05:06:09 UTC) #4
yhirano
lgtm and I think you don't need wtf changes any more.
6 years, 6 months ago (2014-06-26 05:12:28 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-26 05:58:00 UTC) #6
jochen (gone - plz use gerrit)
given that you don't need RemoveVector<> anymore, you shouldn't need my approval?
6 years, 6 months ago (2014-06-26 14:52:00 UTC) #7
tasak
On 2014/06/26 05:12:28, yhirano wrote: > lgtm and I think you don't need wtf changes ...
6 years, 6 months ago (2014-06-27 02:01:17 UTC) #8
tasak
jochen, thank you for comments. On 2014/06/26 14:52:00, jochen wrote: > given that you don't ...
6 years, 6 months ago (2014-06-27 02:02:04 UTC) #9
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-27 03:43:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/350863002/80001
6 years, 6 months ago (2014-06-27 03:43:49 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 04:14:52 UTC) #12
Message was sent while issue was closed.
Change committed as 177060

Powered by Google App Engine
This is Rietveld 408576698