Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 350763005: [Telemetry] Power metric: subtract quiescent power draw from result (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/memory.py ('k') | tools/perf/measurements/page_cycler_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index bb394b089b3cccf0a550927112ce5a38189b8423..babf272f39b8b21f85ab13c5ac4ab891f07d4759 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -39,7 +39,7 @@ class PageCycler(page_measurement.PageMeasurement):
self._speedindex_metric = speedindex.SpeedIndexMetric()
self._memory_metric = None
- self._power_metric = power.PowerMetric()
+ self._power_metric = None
self._cpu_metric = None
self._v8_object_stats_metric = None
self._has_loaded_page = collections.defaultdict(int)
@@ -81,6 +81,10 @@ class PageCycler(page_measurement.PageMeasurement):
else:
cls._cold_run_start_index = args.pageset_repeat * args.page_repeat
+ def WillStartBrowser(self, browser):
+ """Initialize metrics once right before the browser has been launched."""
+ self._power_metric = power.PowerMetric(browser)
+
def DidStartBrowser(self, browser):
"""Initialize metrics once right after the browser has been launched."""
self._memory_metric = memory.MemoryMetric(browser)
« no previous file with comments | « tools/perf/measurements/memory.py ('k') | tools/perf/measurements/page_cycler_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698