Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/gn/ninja_copy_target_writer.cc

Issue 350743004: Allow dependencies of toolchains in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_copy_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_copy_target_writer.cc
diff --git a/tools/gn/ninja_copy_target_writer.cc b/tools/gn/ninja_copy_target_writer.cc
index 4f8534f8edfa3cd2f5208ad18678d9a700510985..06c72df3d32695174ad85c5cd3fa389fe1ee847e 100644
--- a/tools/gn/ninja_copy_target_writer.cc
+++ b/tools/gn/ninja_copy_target_writer.cc
@@ -25,6 +25,9 @@ void NinjaCopyTargetWriter::Run() {
std::string rule_prefix = helper_.GetRulePrefix(target_->settings());
+ std::string implicit_deps =
+ WriteInputDepsStampAndGetDep(std::vector<const Target*>());
+
for (size_t i = 0; i < target_->sources().size(); i++) {
const SourceFile& input_file = target_->sources()[i];
@@ -40,7 +43,7 @@ void NinjaCopyTargetWriter::Run() {
path_output_.WriteFile(out_, output_file);
out_ << ": " << rule_prefix << "copy ";
path_output_.WriteFile(out_, input_file);
- out_ << std::endl;
+ out_ << implicit_deps << std::endl;
}
// Write out the rule for the target to copy all of them.
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_copy_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698