Issue 350743004: Allow dependencies of toolchains in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350743004: Allow dependencies of toolchains in GN. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Allow dependencies of toolchains in GN. A toolchain definition can now specify "deps" which will be resolved before any target in that toolchain is compiled. This is useful for toolchain setup operations. R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280052

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -53 lines)			Patch
M	build/toolchain/gcc_toolchain.gni	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/gn/builder.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/builder.cc	View	3 chunks	+26 lines, -5 lines	0 comments	Download
M	tools/gn/builder_unittest.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	tools/gn/function_toolchain.cc	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	tools/gn/ninja_copy_target_writer.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/gn/ninja_copy_target_writer_unittest.cc	View	2 chunks	+44 lines, -36 lines	0 comments	Download
M	tools/gn/ninja_target_writer.cc	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	tools/gn/ninja_target_writer_unittest.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	tools/gn/toolchain.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

noelallen1

My first look at the GN source, so LGTM for what that's worth.

6 years, 6 months ago (2014-06-26 18:09:03 UTC) #2

brettw

6 years, 6 months ago (2014-06-26 18:12:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r280052 (presubmit successful).