Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 350683003: Turn assert into RUNTIME_ASSERT (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Turn assert into RUNTIME_ASSERT TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 6 months ago (2014-06-23 09:48:25 UTC) #1
dcarney
lgtm
6 years, 6 months ago (2014-06-23 09:51:00 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-06-23 09:52:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698