Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 350683002: [fsp] Add notifications in case of slow operations. (Closed)

Created:
6 years, 6 months ago by mtomasz
Modified:
6 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Add notifications in case of slow operations. Previously, every request was aborted automatically if it took more than 10 seconds. However, for remote file systems using eg HTTP, on slow connection operation can take longer. Another situation is when a providing extension shows a dialog for eg. password or credentials. We don't want to abort an operation in such case. This CL introduces a notification which is shown when an operation takes longer than expected. Users can abort the operation by clicking on the 'ABORT' button. TEST=unit_tests: *FileSystemProvider*Timeout* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279541

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fixed ASAN. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed clang. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -38 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 2 chunks +1 line, -2 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/notification_manager.h View 1 chunk +82 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/notification_manager.cc View 1 2 3 4 1 chunk +161 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/notification_manager_interface.h View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 2 3 5 chunks +55 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager_unittest.cc View 8 chunks +100 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
mtomasz
@kinaba: PTAL. Thanks.
6 years, 6 months ago (2014-06-23 08:28:25 UTC) #1
kinaba
lgtm
6 years, 6 months ago (2014-06-24 05:56:17 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-24 05:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/350683002/40001
6 years, 6 months ago (2014-06-24 06:01:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-24 06:28:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 06:30:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/164361) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/153646) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-24 06:30:35 UTC) #7
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-24 07:16:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/350683002/60001
6 years, 6 months ago (2014-06-24 07:18:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-24 09:17:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 09:29:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/25614)
6 years, 6 months ago (2014-06-24 09:29:39 UTC) #12
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-24 10:01:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/350683002/80001
6 years, 6 months ago (2014-06-24 10:02:54 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 13:00:49 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 14:00:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21395)
6 years, 6 months ago (2014-06-24 14:00:19 UTC) #17
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-24 14:02:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/350683002/80001
6 years, 6 months ago (2014-06-24 14:05:17 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 14:37:02 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 15:17:01 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21436)
6 years, 6 months ago (2014-06-24 15:17:01 UTC) #22
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-24 23:11:42 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/350683002/80001
6 years, 6 months ago (2014-06-24 23:14:31 UTC) #24
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 23:16:48 UTC) #25
Message was sent while issue was closed.
Change committed as 279541

Powered by Google App Engine
This is Rietveld 408576698