Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 350653008: Move ENABLE_MEDIA_CAPTURE to a runtime flag (Closed)

Created:
6 years, 6 months ago by lgombos
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move ENABLE_MEDIA_CAPTURE to a runtime flag The effort needs 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove the build time flag BUG=388093 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176812

Patch Set 1 : Create a runtime flag for MediaCapture to replace the build flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
ptal - 1st step.
6 years, 6 months ago (2014-06-24 03:38:29 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-24 05:15:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/350653008/1
6 years, 6 months ago (2014-06-24 05:15:52 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 05:19:23 UTC) #4
Message was sent while issue was closed.
Change committed as 176812

Powered by Google App Engine
This is Rietveld 408576698