Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart

Issue 350573002: Make retained size human-readable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/vmservice/client/lib/src/elements/class_view.dart ('K') | « runtime/bin/vmservice/client/lib/src/elements/class_view.html ('k') | runtime/bin/vmservice/client/lib/src/elements/instance_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (revision 37564)
+++ runtime/bin/vmservice/client/lib/src/elements/instance_view.dart (working copy)
@@ -13,6 +13,7 @@
class InstanceViewElement extends ObservatoryElement {
@published ServiceMap instance;
@published ServiceMap path;
+ @published int retainedBytes = null;
Cutch 2014/06/23 16:16:39 @observable ?
koda 2014/06/23 18:44:09 Done.
InstanceViewElement.created() : super.created();
@@ -23,7 +24,10 @@
// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
Future<ServiceObject> retainedSize(var dummy) {
- return instance.isolate.get(instance.id + "/retained");
+ return instance.isolate.get(instance.id + "/retained")
+ .then((ServiceMap obj) {
+ retainedBytes = int.parse(obj['valueAsString']);
+ });
}
Future<ServiceObject> retainingPath(var arg) {
« runtime/bin/vmservice/client/lib/src/elements/class_view.dart ('K') | « runtime/bin/vmservice/client/lib/src/elements/class_view.html ('k') | runtime/bin/vmservice/client/lib/src/elements/instance_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698