Issue 350433004: Revert of Remove WebElement::hasTagName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350433004: Revert of Remove WebElement::hasTagName. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
keishi, Ilya Sherman

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert of Remove WebElement::hasTagName. (https://codereview.chromium.org/354763002/) Reason for revert: Broke Android build. Original issue's description: > Remove WebElement::hasTagName. > > There are no callsites in Chromium. This function is unsafe because it > ignores namespace URI. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176895 TBR=keishi@chromium.org,isherman@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176906

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -2 lines)			Patch
M	Source/web/WebElement.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/web/tests/WebViewTest.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	public/web/WebElement.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/350433004/1

6 years, 6 months ago (2014-06-25 04:07:51 UTC) #2

Message was sent while issue was closed.

Change committed as 176906