Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: Source/devtools/front_end/sdk/BreakpointManager.js

Issue 350403004: DevTools: Fix breakpoints in source mapped files after reload. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/inspector/sources/debugger/breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 680 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 }, 691 },
692 692
693 /** 693 /**
694 * @param {boolean=} callbackImmediately 694 * @param {boolean=} callbackImmediately
695 */ 695 */
696 _removeFromDebugger: function(callbackImmediately) 696 _removeFromDebugger: function(callbackImmediately)
697 { 697 {
698 this._resetLocations(); 698 this._resetLocations();
699 if (!this._debuggerId) 699 if (!this._debuggerId)
700 return; 700 return;
701 this.target().debuggerModel.removeBreakpoint(this._debuggerId, callbackI mmediately ? undefined : this._didRemoveFromDebugger.bind(this)); 701 var debuggerId = this._debuggerId;
702 this.target().debuggerModel.removeBreakpoint(this._debuggerId, callbackI mmediately ? undefined : didRemoveFromDebugger.bind(this));
702 703
704 /**
705 * @this {WebInspector.BreakpointManager.TargetBreakpoint}
706 */
707 function didRemoveFromDebugger()
708 {
709 if (this._debuggerId === debuggerId)
710 this._didRemoveFromDebugger();
711 }
703 if (callbackImmediately) 712 if (callbackImmediately)
704 this._didRemoveFromDebugger(); 713 this._didRemoveFromDebugger();
705 }, 714 },
706 715
707 _updateInDebugger: function() 716 _updateInDebugger: function()
708 { 717 {
709 this._removeFromDebugger(); 718 this._removeFromDebugger();
710 var uiSourceCode = this._breakpoint.uiSourceCode(); 719 var uiSourceCode = this._breakpoint.uiSourceCode();
711 if (!uiSourceCode || !this._breakpoint._enabled) 720 if (!uiSourceCode || !this._breakpoint._enabled)
712 return; 721 return;
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 { 899 {
891 this.sourceFileId = breakpoint._sourceFileId; 900 this.sourceFileId = breakpoint._sourceFileId;
892 this.lineNumber = breakpoint.lineNumber(); 901 this.lineNumber = breakpoint.lineNumber();
893 this.columnNumber = breakpoint.columnNumber(); 902 this.columnNumber = breakpoint.columnNumber();
894 this.condition = breakpoint.condition(); 903 this.condition = breakpoint.condition();
895 this.enabled = breakpoint.enabled(); 904 this.enabled = breakpoint.enabled();
896 } 905 }
897 906
898 /** @type {!WebInspector.BreakpointManager} */ 907 /** @type {!WebInspector.BreakpointManager} */
899 WebInspector.breakpointManager; 908 WebInspector.breakpointManager;
OLDNEW
« no previous file with comments | « LayoutTests/inspector/sources/debugger/breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698