Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: Source/build/scripts/make_style_builder.py

Issue 350333003: Cascade declared property values instead of applying values on top of each other (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/build/scripts/templates/StyleBuilder.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_style_builder.py
diff --git a/Source/build/scripts/make_style_builder.py b/Source/build/scripts/make_style_builder.py
index 6c39b332e19b3a8f2af8566ad292eb99d82de35a..d7cc12df0cbbc8a61cd3abc50d6bd492dcfe6fca 100755
--- a/Source/build/scripts/make_style_builder.py
+++ b/Source/build/scripts/make_style_builder.py
@@ -49,16 +49,13 @@ class StyleBuilderWriter(in_generator.Writer):
'custom_initial': [True, False],
'custom_inherit': [True, False],
'custom_value': [True, False],
- 'direction_aware': [True, False],
'skip': [True, False],
}
defaults = {
'name_for_methods': None,
- 'use_handlers_for': None,
'svg': False,
'font': False,
'converter': None,
- 'direction_aware': False,
'skip': False,
# These depend on property name by default
'type_name': None,
@@ -99,7 +96,7 @@ class StyleBuilderWriter(in_generator.Writer):
property['custom_initial'] = True
property['custom_inherit'] = True
property['custom_value'] = True
- property['should_declare_functions'] = not property['use_handlers_for'] and not property['direction_aware'] and not property['skip']
+ property['should_declare_functions'] = not property['skip']
self._properties = dict((property['property_id'], property) for property in self._properties)
« no previous file with comments | « no previous file | Source/build/scripts/templates/StyleBuilder.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698