Cascade declared property values instead of applying values on top of each other

Source/core/css/resolver/CascadedValues.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CascadedValues_h
+#define CascadedValues_h
+
+#include "core/CSSPropertyNames.h"
+#include "core/css/RuleSet.h"
+#include "core/css/SelectorChecker.h"
+#include "core/rendering/style/RenderStyleConstants.h"
+#include "platform/text/TextDirection.h"
+#include "platform/text/WritingMode.h"
+
+namespace blink {
+
+class CSSValue;
+class MatchResult;
+class StyleResolverState;
+class StyleRule;
+
+class CascadedValues {
+    STACK_ALLOCATED();
+public:
+    CascadedValues(StyleResolverState&, const MatchResult&);
+
+    void addMatchResult(const MatchResult&, bool isImportant, int firstIndex, int lastIndex);
+    void applyValues(CSSPropertyID first, CSSPropertyID last, bool inheritedOnly = false);
+
+private:
+    void addMatchResultInternal(const MatchResult&, bool isImportant, int firstIndex, int lastIndex, CSSPropertyID firstId, CSSPropertyID lastId);
+    void addStylePropertySet(const StylePropertySet*, const StyleRule*, bool isImportant, CSSPropertyID first, CSSPropertyID last, PropertyWhitelistType, SelectorChecker::LinkMatchMask);
+    void addValue(CSSPropertyID, CSSValue*, const StyleRule*, SelectorChecker::LinkMatchMask);
+    void addAllProperty(CSSValue*, SelectorChecker::LinkMatchMask);
+
+    CSSValue* values[numCSSProperties];
+    CSSValue* visitedLinkValues[numCSSProperties];
+
+    StyleResolverState& state;
+    TextDirection direction;
+    WritingMode writingMode;

[esprehn, 2014/07/21 18:50:34]

Missing m_ on all the members.

[Timothy Loh, 2014/07/22 14:32:48]

Oops, fixed.

+};
+
+} // namespace blink
+
+#endif // CascadedValues_h