Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 350293004: Oilpan: fix build after r177060 (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r177060 Add missing & now-needed V8ValueTraits<> specialization for HeapVector. R=haraken@chromium.org BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/bindings/v8/V8Binding.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sof
Please take a look. (I can't immediately see any in-flight CLs addressing this already, but ...
6 years, 6 months ago (2014-06-27 05:29:24 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-27 05:37:02 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-27 05:40:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/350293004/1
6 years, 6 months ago (2014-06-27 05:40:40 UTC) #4
Mads Ager (chromium)
LGTM2
6 years, 6 months ago (2014-06-27 06:39:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-27 07:49:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-27 07:55:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/1940)
6 years, 6 months ago (2014-06-27 07:55:01 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-27 08:05:10 UTC) #9
tkent
You may apply TBR= and "git cl dcommit" for build fix CLs.
6 years, 6 months ago (2014-06-27 08:06:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/350293004/1
6 years, 6 months ago (2014-06-27 08:06:13 UTC) #11
sof
On 2014/06/27 08:06:12, tkent wrote: > You may apply TBR= and "git cl dcommit" for ...
6 years, 6 months ago (2014-06-27 08:09:07 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 08:17:41 UTC) #13
Message was sent while issue was closed.
Change committed as 177079

Powered by Google App Engine
This is Rietveld 408576698