Remove an unneccessary special case for the main resource from InspectorPageAgent

Remove an unneccessary special case for the main resource from InspectorPageClient

Miniature cleanup, the special case is not needed as the default: case handles
main resources well: it returns early with false as resourceBuffer() is null.

R=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177032

[pfeldman, 2014-06-25 15:31:58]

Why would we want to rely upon this implicit fact? What if this behavior
changes?

[kbalazs, 2014-06-25 15:43:57]

On 2014/06/25 15:31:58, pfeldman wrote:
> Why would we want to rely upon this implicit fact? What if this behavior
> changes?

Right, but actually the thing is that right now we rely on the implicit fact
that main resources are not cached. Without the extra case this thing can work
now it can also work if we decide to cache them (in this case it will have a
resource buffer that we can use). I was investigating this and found that I need
to remove this condition to make some tests pass when main resources are cache,
that was my motivation.

[vsevik, 2014-06-25 15:51:38]

> I need to remove this condition to make some tests pass when main resources
are cache, that was my motivation.
Could you please elaborate what tests are you talking about? Shouldn't they be
included in this patch?

[kbalazs, 2014-06-25 16:59:05]

On 2014/06/25 15:51:38, vsevik wrote:
> > I need to remove this condition to make some tests pass when main resources
> are cache, that was my motivation.
> Could you please elaborate what tests are you talking about? Shouldn't they be
> included in this patch?

LOL, I meant layout tests in the inspector folder.
inspector/network/async-xhr-json-mime-type.html is the one I remember.

[vsevik, 2014-06-26 16:23:13]

This test is currently passing on the bots, are you making some change that
breaks it without this patch? Can you share a link on the CL?

lgtm

[vsevik, 2014-06-26 16:23:19]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-06-26 16:24:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/350263002/1

[kbalazs, 2014-06-26 19:16:44]

On 2014/06/26 16:23:13, vsevik wrote:
> This test is currently passing on the bots, are you making some change that
> breaks it without this patch? Can you share a link on the CL?
> 
> lgtm

Removing this branch:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Btw most of the loading code is already handles caching main resources although
we don't do it (it has been implemented just before the fork, but kept being
disabled for chromium).

This is an experiment, no CL, at least not for now.

Thanks for the review.

[commit-bot: I haz the power, 2014-06-26 19:48:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13871)

[commit-bot: I haz the power, 2014-06-27 00:54:34]

Change committed as 177032