Issue 35023003: Change javascript string replace in ant files to pure ant using a filterchain with replacestring

Issue 35023003: Change javascript string replace in ant files to pure ant using a filterchain with replacestring (Closed)

Created:
7 years, 2 months ago by ian_cottrell

Modified:
7 years, 2 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@java-normal

Visibility:
Public.

More Reviews

Description

Change javascript string replace in ant files to pure ant using a filterchain with replacestring BUG=310065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230421

Patch Set 2 : Fix for empty source variable not setting target variable" #

Total comments: 1

Patch Set 3 : Remove the unnecesary tokenfilter wrapper around replacestring #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	build/android/ant/apk-codegen.xml	View	1 2	2 chunks	+10 lines, -5 lines	0 comments	Download
	M	build/android/ant/apk-package-resources.xml	View	1 2	2 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cjhopman

lgtm https://codereview.chromium.org/35023003/diff/40001/build/android/ant/apk-codegen.xml File build/android/ant/apk-codegen.xml (right): https://codereview.chromium.org/35023003/diff/40001/build/android/ant/apk-codegen.xml#newcode59 build/android/ant/apk-codegen.xml:59: <replacestring from=" " to=";"/> Ant documentation says that ...

7 years, 2 months ago (2013-10-22 21:22:27 UTC) #2

ian_cottrell

On 2013/10/22 21:22:27, cjhopman wrote: > lgtm > > https://codereview.chromium.org/35023003/diff/40001/build/android/ant/apk-codegen.xml > File build/android/ant/apk-codegen.xml (right): > ...

7 years, 2 months ago (2013-10-23 11:19:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/35023003/140001

7 years, 2 months ago (2013-10-23 11:22:07 UTC) #4

Message was sent while issue was closed.

Change committed as 230421

Expand Messages | Collapse Messages