Issue 350173004: [android_webview] Enable new android_webview resource target on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350173004: [android_webview] Enable new android_webview resource target on Android. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)

Modified:
6 years, 6 months ago

Reviewers:
Torne

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android_webview] Enable new android_webview resource target on Android. This enables compiling the android_webview_java target against R.java files generated by aapt (and not against the static resource map files). BUG=387155 TEST=compile on android_aosp bot Change only relevant to android_aosp, builds fine there. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279402

Patch Set 1 #

Patch Set 2 : put the slash in the right way around #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
M	android_webview/Android.mk	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	android_webview/build/res_hack/values/values.xml	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	android_webview/build/resources_config.mk	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mkosiba (inactive)

The CQ bit was checked by mkosiba@chromium.org

6 years, 6 months ago (2014-06-24 14:38:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/350173004/20001

6 years, 6 months ago (2014-06-24 14:39:53 UTC) #4

Message was sent while issue was closed.

Change committed as 279402

Expand Messages | Collapse Messages