Add accessibility_unittests and chromevox_tests to buildbot config.

Add accessibility_unittests and chromevox_tests to buildbot config.

accessibility_unittests should run everywhere except iOS. It's small and
very fast.

chromevox_tests is only for Chromium OS.

BUG=322537
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280566

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282050

[Paweł Hajdan Jr., 2014-06-24 18:12:19]

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.ch...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.ch...
testing/buildbot/chromium.chromiumos.json:51: "Linux ChromiumOS Tests (dbg)(1)":
{
Please also add these tests to dbg bots.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.li...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.li...
testing/buildbot/chromium.linux.json:166: "Linux Tests (dbg)(2)": {
Please also add to dbg.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:27: "test": "chromeos_unittests",
That's surprising - I see chromeos_unittests added here while other tests get
added to the main waterfall builders. Make the tryserver config match the main
waterfall config.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:28: "platforms": ["linux"],
nit: This is not needed since chromium_configs includes chromeos which implies
linux.

[dmazzoni, 2014-06-24 19:31:49]

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.ch...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.ch...
testing/buildbot/chromium.chromiumos.json:51: "Linux ChromiumOS Tests (dbg)(1)":
{
On 2014/06/24 18:12:18, Paweł Hajdan Jr. wrote:
> Please also add these tests to dbg bots.

Done for accessibility_unittests.

I didn't add chromevox_tests because they're more heavyweight (more like
browser_tests) and because they're all-JavaScript - so debug is unlikely to
catch anything different. We have other integration tests that would catch
ChromeVox issues in debug mode.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.li...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium.li...
testing/buildbot/chromium.linux.json:166: "Linux Tests (dbg)(2)": {
On 2014/06/24 18:12:18, Paweł Hajdan Jr. wrote:
> Please also add to dbg.

Done. I added it to a few more places - anywhere base_unittests was run
currently.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:27: "test": "chromeos_unittests",
On 2014/06/24 18:12:18, Paweł Hajdan Jr. wrote:
> That's surprising - I see chromeos_unittests added here while other tests get
> added to the main waterfall builders. Make the tryserver config match the main
> waterfall config.

Oops, this was a typo. I meant this to be chromevox_tests.

accessibility_unittests was already in the trybot config, I didn't need to add
it.

https://codereview.chromium.org/350123003/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:28: "platforms": ["linux"],
On 2014/06/24 18:12:18, Paweł Hajdan Jr. wrote:
> nit: This is not needed since chromium_configs includes chromeos which implies
> linux.

Done.

[dmazzoni, 2014-06-26 17:35:34]

Ping?

[Paweł Hajdan Jr., 2014-06-26 22:31:47]

LGTM

[Peter Lundblad, 2014-06-27 00:16:43]

I am currently looking into a breakage that happens on debug builds only (the
culpit seems to be 
https://codereview.chromium.org/285333003) leading me to think that it might be
worth having these tests run on the debug bots as well.

[David Tseng, 2014-06-27 01:14:01]

+1; I have learned to always build debug due to past experiences. Would be
nice to build release to iterate more rapidly and have the bots catch
lingering issues.


On Thu, Jun 26, 2014 at 5:16 PM, <plundblad@chromium.org> wrote:

> I am currently looking into a breakage that happens on debug builds only
> (the
> culpit seems to be
> https://codereview.chromium.org/285333003) leading me to think that it
> might be
> worth having these tests run on the debug bots as well.
>
>
> https://codereview.chromium.org/350123003/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2014-06-27 19:53:18]

OK, FYI I'm going to commit this as-is and add chromevox_tests to a debug config
in a follow-up since one of the tests is failing there now.

[dmazzoni, 2014-06-27 19:53:25]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-06-27 19:55:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/350123003/20001

[commit-bot: I haz the power, 2014-06-27 23:04:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-28 00:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-28 00:10:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[dmazzoni, 2014-06-30 05:04:27]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-06-30 05:05:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/350123003/20001

[commit-bot: I haz the power, 2014-06-30 06:40:46]

Change committed as 280566

[Timothy Loh, 2014-06-30 12:52:43]

A revert of this CL has been created in
https://codereview.chromium.org/338843007/ by timloh@chromium.org.

The reason for reverting is: The chromevox tests are failing (and blocking cq
trybots)..

[dmazzoni, 2014-07-09 15:59:41]

Re-landing now that the chromevox_tests debug failures are fixed.

[dmazzoni, 2014-07-09 15:59:56]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-07-09 16:01:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/350123003/40001

[commit-bot: I haz the power, 2014-07-09 16:02:38]

Change committed as 282050