Issue 3501007: Merge r5518 into 2.3 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3501007: Merge r5518 into 2.3 branch. (Closed)

Created:
10 years, 3 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
vegorov, Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/2.3/

Visibility:
Public.

Description

Merge r5518 into 2.3 branch. Fix assertion failure in NormalizedMapCache. Committed: http://code.google.com/p/v8/source/detail?r=5522

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -65 lines)			Patch
M	src/objects.h	View	6 chunks	+19 lines, -6 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+35 lines, -56 lines	0 comments	Download
M	src/objects-debug.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+13 lines, -0 lines	2 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM. thanks! http://codereview.chromium.org/3501007/diff/13002/10003 File src/objects-inl.h (right): http://codereview.chromium.org/3501007/diff/13002/10003#newcode2270 src/objects-inl.h:2270: there is something odd with blank lines ...

10 years, 3 months ago (2010-09-24 10:19:43 UTC) #4

Vladislav Kaznacheev

10 years, 3 months ago (2010-09-24 10:24:46 UTC) #5

Thanks, committing.

http://codereview.chromium.org/3501007/diff/13002/10003
File src/objects-inl.h (right):

http://codereview.chromium.org/3501007/diff/13002/10003#newcode2270
src/objects-inl.h:2270: 
On 2010/09/24 10:19:43, Vyacheslav Egorov wrote:
> there is something odd with blank lines here.
> 

Done.

Expand Messages | Collapse Messages

Issue 3501007: Merge r5518 into 2.3 branch. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages