Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 350043003: Add more cases of box-sizing change (Closed)

Created:
6 years, 6 months ago by Xianzhu
Modified:
6 years, 6 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add more cases of box-sizing change - Add cases of changing box-sizing and border at the same time while keeping the actual size; - Add cases of changing box-sizing and padding at the same time while keeping the actual size; - Add cases changing box-sizing from content-box to border-box. BUG=375876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -7 lines) Patch
M LayoutTests/fast/repaint/box-sizing.html View 2 chunks +13 lines, -5 lines 0 comments Download
A LayoutTests/fast/repaint/box-sizing-border-keeping-size.html View 1 chunk +32 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/box-sizing-border-keeping-size-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/box-sizing-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/box-sizing-padding-keeping-size.html View 1 chunk +32 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/box-sizing-padding-keeping-size-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
This is to Re ojan@'s (OOO for now) suggestion in https://codereview.chromium.org/348493003/. Note that the repaint ...
6 years, 6 months ago (2014-06-23 18:49:08 UTC) #1
esprehn
lgtm, I assume you verified they do actually repaint properly?
6 years, 6 months ago (2014-06-23 18:52:17 UTC) #2
Xianzhu
On 2014/06/23 18:52:17, esprehn wrote: > lgtm, I assume you verified they do actually repaint ...
6 years, 6 months ago (2014-06-23 18:53:27 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-06-23 18:54:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/350043003/1
6 years, 6 months ago (2014-06-23 18:54:29 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 20:10:07 UTC) #6
Message was sent while issue was closed.
Change committed as 176783

Powered by Google App Engine
This is Rietveld 408576698