Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 350023002: More Map methods moved to private part. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

More Map methods moved to private part. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21985

Patch Set 1 #

Patch Set 2 : Addressed comment and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 3 chunks +19 lines, -8 lines 0 comments Download
M src/objects.cc View 1 6 chunks +13 lines, -14 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 6 months ago (2014-06-23 17:43:58 UTC) #1
Toon Verwaest
lgtm
6 years, 6 months ago (2014-06-24 13:21:19 UTC) #2
Igor Sheludko
6 years, 5 months ago (2014-06-24 15:57:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698