Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 350013003: WebLeakDetector: Fix false positive leaks on worker tests when oilpan is enabled. (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

WebLeakDetector: Fix false positive leaks on worker tests when oilpan is enabled. This patch adds another round of GC to make sure Document is destroyed after |WorkerMessagingProxy::workerObjectDestroyed|. BUG=389042 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177043

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/web/WebLeakDetector.cpp View 3 chunks +10 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
6 years, 5 months ago (2014-06-26 23:57:26 UTC) #1
tkent
lgtm https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp File Source/web/WebLeakDetector.cpp (right): https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp#newcode64 Source/web/WebLeakDetector.cpp:64: , m_numberOfGCNeeded(0) We can initialize it with 2.
6 years, 5 months ago (2014-06-27 00:10:55 UTC) #2
tkent
https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp File Source/web/WebLeakDetector.cpp (right): https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp#newcode64 Source/web/WebLeakDetector.cpp:64: , m_numberOfGCNeeded(0) On 2014/06/27 00:10:55, tkent wrote: > We ...
6 years, 5 months ago (2014-06-27 00:11:56 UTC) #3
kouhei (in TOK)
On 2014/06/27 00:11:56, tkent wrote: > https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp > File Source/web/WebLeakDetector.cpp (right): > > https://codereview.chromium.org/350013003/diff/1/Source/web/WebLeakDetector.cpp#newcode64 > ...
6 years, 5 months ago (2014-06-27 00:13:17 UTC) #4
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-06-27 00:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/350013003/1
6 years, 5 months ago (2014-06-27 00:14:02 UTC) #6
haraken
LGTM
6 years, 5 months ago (2014-06-27 00:44:05 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 02:14:38 UTC) #8
Message was sent while issue was closed. 
Change committed as 177043

Powered by Google App Engine
This is Rietveld 408576698