Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 349983002: Revert of Add functions to support NV_path_rendering in OpenGL ES (Closed)

Created:
6 years, 6 months ago by rmistry
Modified:
6 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@desktop-es
Visibility:
Public.

Description

Revert of Add functions to support NV_path_rendering in OpenGL ES (https://codereview.chromium.org/345723002/) Reason for revert: Will have to unfortunately revert this CL in order to revert https://codereview.chromium.org/319043005/ Original issue's description: > Add functions to support NV_path_rendering in OpenGL ES > > Add OpenGL ES extension functions needed to support NV_path_rendering in OpenGL > ES. > > The added glProgramPathFragmentInputGenNV call is defined in NV_path_rendering > revision 30, similar to following: > > Append to the end of the "Shader Inputs" subsection of Section 3.12.2 > "Shader Execution": > > The command > > void ProgramPathFragmentInputGenNV(uint program, > int location, > enum genMode, > int components, > const float *coeffs); > > controls how a user-defined (non-built-in) fragment input of a > GLSL program object is computed for fragment shading operations that > occur as a result of CoverFillPathNV or CoverStrokePathNV. > > /program/ names a GLSL program object. If /program/ has not been > successfully linked, the error INVALID_OPERATION is generated. > > The given fragment input generation state is loaded into the fragment > input variable location identified by /location/. This location > is a value returned either by GetProgramResourceLocation with a > /programInterface/ of FRAGMENT_INPUT_NV and a given fragment shader > input variable name or by GetProgramResourceiv with FRAGMENT_INPUT_NV > for the /programInterface/ and LOCATION for the property for a given > fragment input resource index. > > .... > > glProgramPathFragmentInputGenNV will be used instead of glPathTexGen, > because the latter depends on fixed function pipeline that is not > exposed in ES. > > Also add glGetProgramResourceLocation from OpenGL 4.3 or > ARB_program_interface_query. > > Also add FRAGMENT_INPUT define to be used with glGetProgramResourceLocation. > > The added functions are not used yet, but they're needed when implementing > NV_path_rendering support for OpenGL ES. They can also be used on OpenGL. > > Remove uncalled NV_path_rendering functions, so they do not cause confusion > or take space in the interface definition. The ones that are later used > can be re-added when needed. > > Remove definitions NV_path_rendering that are for NV_path_rendering function > parameters that are not used. The ones that are later used > can be re-added when needed. > > Committed: https://skia.googlesource.com/skia/+/4a995dfff2ecf91e8bf999d77e3218cec596232c TBR=bsalomon@google.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c986b1fd284a63413c3bd2be8acb6dcd5c7e7532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -95 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 2 chunks +26 lines, -6 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +33 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleGLESInterface.h View 1 chunk +0 lines, -32 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +33 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 4 chunks +77 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 3 chunks +94 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Add functions to support NV_path_rendering in OpenGL ES
6 years, 6 months ago (2014-06-23 13:06:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/349983002/1
6 years, 6 months ago (2014-06-23 13:06:31 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 13:06:40 UTC) #3
Message was sent while issue was closed.
Change committed as c986b1fd284a63413c3bd2be8acb6dcd5c7e7532

Powered by Google App Engine
This is Rietveld 408576698