Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 349973006: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (multiple … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 385f7ee088b0d2f72e17a66f06fe6ff430d477e0..fc5e12f7b4309c6b5314239efe3e166b638f1cb7 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -2712,8 +2712,8 @@ void HTMLMediaElement::sourceWasAdded(HTMLSourceElement* source)
return;
}
- if (m_currentSourceNode && source == m_currentSourceNode->nextSibling()) {
- WTF_LOG(Media, "HTMLMediaElement::sourceWasAdded - <source> inserted immediately after current source");
+ if (!m_currentSourceNode || source == m_currentSourceNode->nextSibling()) {
+ WTF_LOG(Media, "HTMLMediaElement::sourceWasAdded - no current source or <source> inserted immediately after current source");
m_nextChildNodeToConsider = source;
return;
}

Powered by Google App Engine
This is Rietveld 408576698