LayoutTests/media/media-source-append-multiple.html - Issue 349973006: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (multiple …

Side by Side Diff: LayoutTests/media/media-source-append-multiple.html

Issue 349973006: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (multiple … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src=media-file.js></script>

	5 <script src=video-test.js></script>

	6 <script>

	7 var audio, sourceA, sourceB;

	8 function logEvent(audio, name) {
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 Remove. You should be using waitForEvent instead. Remove. You should be using waitForEvent instead. Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > Remove. You should be using waitForEvent instead. Done.
	9 audio.addEventListener(name, function(e) {

	10 consoleWrite("EVENT(" + e.type + ")");

	11 });

	12 }

	13

	14 function canplaythrough(e) {

	15 consoleWrite("EVENT(canplaythrough)");

	16 endTest();
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 Add a check before this that makes sure that curre Add a check before this that makes sure that currentSrc still equals the sourceA URL? Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > Add a check before this that makes sure that currentSrc still equals the sourceA > URL? Done.
	17 }

	18

	19 function loadedMetadataA() {
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 nit: { on next line here an every other instance l nit: { on next line here an every other instance like this. Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > nit: { on next line here an every other instance like this. Done.
	20 consoleWrite("loadedMetadataA");

	21 audio.removeEventListener("loadedmetadata", loadedMetadataA);

	22 audio.removeChild(sourceA);

	23 audio.appendChild(sourceB);

	24 audio.addEventListener("loadedmetadata", loadedMetadataB);
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 nit: Use waitForEventAndFail() here instead. nit: Use waitForEventAndFail() here instead. Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > nit: Use waitForEventAndFail() here instead. Done.
	25 }

	26

	27 function loadedMetadataB() {

	28 consoleWrite("loadedMetadataB");

	29 audio.removeEventListener("loadedmetadata", loadedMetadataB);

	30 failTest("Should not load 2nd Source");

	31 }

	32

	33 function onWindowLoad(e)

	34 {

	35 audio = document.getElementById('a');

	36 logEvent(audio, "loadstart");
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 Why don't you just use waitForEvent() since you ar Why don't you just use waitForEvent() since you are already including video-test.js? This should work if you call findMediaElement() at the top of this function. Srirama 2014/06/23 19:19:26 Used waitForEvent() but not able to use findMediaE Used waitForEvent() but not able to use findMediaElement() as it was not finding audio element. On 2014/06/23 16:49:40, acolwell wrote: Show quoted text > Why don't you just use waitForEvent() since you are already including > video-test.js? This should work if you call findMediaElement() at the top of > this function.
	37 logEvent(audio, "progress");

	38 logEvent(audio, "emptied");

	39 logEvent(audio, "suspend");

	40 logEvent(audio, "loadedmetadata");

	41 logEvent(audio, "loadeddata");

	42 logEvent(audio, "canplay");

	43 audio.addEventListener('canplaythrough', canplaythrough);

	44

	45 sourceA = document.createElement("source");

	46 var audioFile = findMediaFile("audio", "content/test");

	47 sourceA.setAttribute("src", audioFile);

	48 sourceB = document.createElement("source");

	49 audioFile = findMediaFile("audio", "content/silence");

	50 sourceB.setAttribute("src", audioFile);

	51

	52 audio.addEventListener("loadedmetadata", loadedMetadataA);
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 nit: Use waitForEventOnce("loadedmetadata", loaded nit: Use waitForEventOnce("loadedmetadata", loadedMetadataA) here so you don't have to remove the event listener above. Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > nit: Use waitForEventOnce("loadedmetadata", loadedMetadataA) here so you don't > have to remove the event listener above. Done.
	53 audio.appendChild(sourceA);

	54 }

	55

	56 window.addEventListener('load', onWindowLoad, false);

	57 </script>

	58 </head>

	59 <body>

	60 <audio id="a" controls></audio>
	acolwell GONE FROM CHROMIUM 2014/06/23 16:49:40 nit: remove controls since it is not needed for th nit: remove controls since it is not needed for this test. Srirama 2014/06/23 19:19:26 Done. Show quoted text On 2014/06/23 16:49:40, acolwell wrote: > nit: remove controls since it is not needed for this test. Done.
	61 </body>

	62 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/media-source-append-multiple-expected.txt » ('j') | no next file with comments »