LayoutTests/media/media-source-append-multiple-expected.txt - Issue 349973006: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (multiple …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/media-source-append-multiple-expected.txt

Issue 349973006: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (multiple … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 EVENT(loadstart)

	2 EVENT(loadedmetadata)

	3 loadedMetadataA

	4 EVENT(progress)

	5 EVENT(suspend)

	6 EVENT(loadeddata)

	7 EVENT(canplay)

	8 EVENT(canplaythrough)

	9 EXPECTED (audio.currentSrc == 'file:///E:/chrome/winchrome/src/third_party/WebKi t/LayoutTests/media/content/test.wav') OK
	acolwell GONE FROM CHROMIUM 2014/06/23 20:30:49 You should not have an absolute URL in the expecta You should not have an absolute URL in the expectations since none of the bots will actually match this. Try using testExpected("audio.currentSrc == sourceA.src", true); Srirama 2014/06/24 07:04:47 Done. Show quoted text On 2014/06/23 20:30:49, acolwell wrote: > You should not have an absolute URL in the expectations since none of the bots > will actually match this. Try using testExpected("audio.currentSrc == > sourceA.src", true); Done.
	10 END OF TEST

	11

OLD	NEW