Issue 349973004: Add verbose option to misc.ChDir

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349973004: Add verbose option to misc.ChDir (Closed)

Created:
6 years, 6 months ago by borenet

Modified:
6 years, 6 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/common.git@master

Visibility:
Public.

More Reviews

Description

Add verbose option to misc.ChDir BUG=skia: R=rmistry@google.com Committed: https://skia.googlesource.com/common/+/a50df31

Patch Set 3 : log -> print #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	py/utils/misc.py	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmistry

LGTM https://codereview.chromium.org/349973004/diff/20001/py/utils/misc.py File py/utils/misc.py (right): https://codereview.chromium.org/349973004/diff/20001/py/utils/misc.py#newcode75 py/utils/misc.py:75: verbose: bool; whether or not to log the ...

6 years, 6 months ago (2014-06-23 14:08:15 UTC) #2

borenet

https://codereview.chromium.org/349973004/diff/20001/py/utils/misc.py File py/utils/misc.py (right): https://codereview.chromium.org/349973004/diff/20001/py/utils/misc.py#newcode75 py/utils/misc.py:75: verbose: bool; whether or not to log the directory ...

6 years, 6 months ago (2014-06-23 14:16:40 UTC) #3

borenet

6 years, 6 months ago (2014-06-23 14:16:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as ra50df31 (presubmit successful).

Expand Messages | Collapse Messages

Issue 349973004: Add verbose option to misc.ChDir (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : log -> print #

Messages