Issue 349943002: Make ASAN happy. Do not call setGamepadProvider on null pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349943002: Make ASAN happy. Do not call setGamepadProvider on null pointer. (Closed)

Created:
6 years, 6 months ago by loislo

Modified:
6 years, 6 months ago

Reviewers:
bajones, kbalazs, jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make ASAN happy. Do not call setGamepadProvider on null pointer. BUG=344556 TBR=bajones, jam, kbalazs Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279081

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/shell/renderer/test_runner/gamepad_controller.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/349943002/1

6 years, 6 months ago (2014-06-23 07:15:12 UTC) #3

kbalazs

6 years, 6 months ago (2014-06-23 18:04:26 UTC) #5

Message was sent while issue was closed.

On 2014/06/23 10:37:52, I haz the power (commit-bot) wrote:
> Change committed as 279081

Thanks for making ASAN happy (and fixing a real bug in my code).

Expand Messages | Collapse Messages