Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 349713002: Android: Remove events extensions API. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, felt, zea+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, haitaol+watch_chromium.org, marja+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Android: Remove events extensions API. BUG=305852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279020

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -42 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 13 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
https://codereview.chromium.org/349713002/diff/20001/chrome/browser/extensions/activity_log/activity_log.h File chrome/browser/extensions/activity_log/activity_log.h (right): https://codereview.chromium.org/349713002/diff/20001/chrome/browser/extensions/activity_log/activity_log.h#newcode44 chrome/browser/extensions/activity_log/activity_log.h:44: // TODO(thestig) Remove ENABLE_EXTENSIONS checks when ActivityLog is no ...
6 years, 6 months ago (2014-06-20 19:41:39 UTC) #1
Yoyo Zhou
LGTM
6 years, 6 months ago (2014-06-21 00:47:09 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-22 19:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/349713002/60001
6 years, 6 months ago (2014-06-22 19:17:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-22 21:23:12 UTC) #5
Message was sent while issue was closed.
Change committed as 279020

Powered by Google App Engine
This is Rietveld 408576698