Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 349703003: [NaCl SDK] Add some more logging to nacl_io. (Closed)

Created:
6 years, 6 months ago by binji
Modified:
6 years, 6 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add some more logging to nacl_io. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279130

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Patch Set 3 : fix linux host build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -197 lines) Patch
M native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.cc View 4 chunks +28 lines, -10 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_event_emitter.cc View 10 chunks +42 lines, -15 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/dir_node.cc View 1 2 4 chunks +16 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/filesystem.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc View 17 chunks +49 lines, -18 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/getdents_helper.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/host_resolver.cc View 7 chunks +18 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.h View 1 chunk +5 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc View 1 10 chunks +44 lines, -29 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.h View 2 chunks +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc View 11 chunks +48 lines, -37 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/jsfs/js_fs.cc View 24 chunks +31 lines, -36 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/jsfs/js_fs_node.cc View 14 chunks +17 lines, -23 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 7 chunks +16 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/log.h View 1 1 chunk +24 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/udp_node.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
6 years, 6 months ago (2014-06-20 18:46:26 UTC) #1
Sam Clegg
lgtm. Although, I think we should remove all logging when NDEBUG is defined... if only ...
6 years, 6 months ago (2014-06-20 19:16:14 UTC) #2
binji
https://codereview.chromium.org/349703003/diff/1/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc File native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc (right): https://codereview.chromium.org/349703003/diff/1/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc#newcode221 native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc:221: LOG_ERROR("Unknown type: '%s'", iter->second.c_str()); On 2014/06/20 19:16:14, Sam Clegg ...
6 years, 6 months ago (2014-06-20 19:38:30 UTC) #3
binji
6 years, 6 months ago (2014-06-23 17:22:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r279130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698