Issue 349703002: MIPS: Support LiveEdit.

Issue 349703002: MIPS: Support LiveEdit. (Closed)

Created:
6 years, 6 months ago by kilvadyb

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow, Paul Lind, danno, kisg, palfia, alph, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Support LiveEdit. Port r21895 (210f7aa) BUG=368580 LOG=Y

Patch Set 2 : Fix comment. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -12 lines)			Patch
M	src/mips/debug-mips.cc	View	1	3 chunks	+36 lines, -3 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

palfia

LGTM , but we need someone from the Google team to approve. Could you please ...

6 years, 6 months ago (2014-06-20 19:33:47 UTC) #2

alph

lgtm https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc File src/mips/debug-mips.cc (right): https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc#newcode330 src/mips/debug-mips.cc:330: // Re-run JSFunction, r1 is function, cp is ...

6 years, 6 months ago (2014-06-21 08:35:54 UTC) #5

kilvadyb

https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc File src/mips/debug-mips.cc (right): https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc#newcode330 src/mips/debug-mips.cc:330: // Re-run JSFunction, r1 is function, cp is context. ...

6 years, 6 months ago (2014-06-21 12:32:16 UTC) #6

alph

On 2014/06/21 12:32:16, kilvadyb wrote: > https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc > File src/mips/debug-mips.cc (right): > > https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc#newcode330 > ...

6 years, 5 months ago (2014-07-02 16:26:13 UTC) #7

kilvadyb

6 years, 5 months ago (2014-07-02 17:00:33 UTC) #8

On 2014/07/02 16:26:13, alph wrote:
> On 2014/06/21 12:32:16, kilvadyb wrote:
> > https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc
> > File src/mips/debug-mips.cc (right):
> > 
> >
>
https://codereview.chromium.org/349703002/diff/1/src/mips/debug-mips.cc#newco...
> > src/mips/debug-mips.cc:330: // Re-run JSFunction, r1 is function, cp is
> context.
> > On 2014/06/21 08:35:54, alph wrote:
> > > nit: s/r1/a1/
> > Thank you for noticing this.
> > 
> > Done.
> 
> Close the CL?

The fix was landed in an an other CL. Thank you for the comment again.

Expand Messages | Collapse Messages