Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4660)

Unified Diff: chrome/browser/policy/schema_registry_service_factory.cc

Issue 349643002: Decoupled the SchemaRegistryService from SchemaRegistry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/schema_registry_service_factory.cc
diff --git a/chrome/browser/policy/schema_registry_service_factory.cc b/chrome/browser/policy/schema_registry_service_factory.cc
index 71758ffc9076cbb1247912cd29ca8f1166599b20..c937500f0e682139b358b54b554f7cda8e1d0f90 100644
--- a/chrome/browser/policy/schema_registry_service_factory.cc
+++ b/chrome/browser/policy/schema_registry_service_factory.cc
@@ -60,10 +60,11 @@ SchemaRegistryServiceFactory::CreateForContextInternal(
CombinedSchemaRegistry* global_registry) {
DCHECK(!context->IsOffTheRecord());
DCHECK(registries_.find(context) == registries_.end());
- SchemaRegistryService* registry =
- new SchemaRegistryService(chrome_schema, global_registry);
- registries_[context] = registry;
- return make_scoped_ptr(registry);
+ scoped_ptr<SchemaRegistry> registry(new SchemaRegistry);
+ SchemaRegistryService* service = new SchemaRegistryService(
bartfab (slow) 2014/06/20 14:48:01 Nit: Since you are updating this part of the code
Joao da Silva 2014/06/20 15:30:14 Done.
+ registry.Pass(), chrome_schema, global_registry);
+ registries_[context] = service;
+ return make_scoped_ptr(service);
}
void SchemaRegistryServiceFactory::BrowserContextShutdown(

Powered by Google App Engine
This is Rietveld 408576698