Decoupled the SchemaRegistryService from SchemaRegistry.

chrome/browser/policy/schema_registry_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_SCHEMA_REGISTRY_SERVICE_H_
 #define CHROME_BROWSER_POLICY_SCHEMA_REGISTRY_SERVICE_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"

[bartfab (slow), 2014/06/20 14:48:01]

Nit: No longer needed.

[Joao da Silva, 2014/06/20 15:30:14]

Done.

 #include "components/keyed_service/core/keyed_service.h"
 #include "components/policy/core/common/schema_registry.h"

[bartfab (slow), 2014/06/20 14:48:01]

Nit: A forward-declaration is sufficient now.

[Joao da Silva, 2014/06/20 15:30:14]

Done.

 
 namespace policy {
 
 class Schema;
 
-// A SchemaRegistry that is also a KeyedService, and is associated
-// with a Profile.
-class SchemaRegistryService : public SchemaRegistry, public KeyedService {
+// A KeyedService associated with a Profile that contains a SchemaRegistry.
+class SchemaRegistryService : public KeyedService {
  public:
-  // This SchemaRegistry will initially contain only the |chrome_schema|, if
+  // This |registry| will initially contain only the |chrome_schema|, if
   // it's valid. The optional |global_registry| must outlive this, and will
-  // track this registry.
-  SchemaRegistryService(const Schema& chrome_schema,
+  // track |registry|.
+  SchemaRegistryService(scoped_ptr<SchemaRegistry> registry,
+                        const Schema& chrome_schema,
                         CombinedSchemaRegistry* global_registry);
   virtual ~SchemaRegistryService();
 
-  // KeyedService:
-  virtual void Shutdown() OVERRIDE;
+  SchemaRegistry* registry() const { return registry_.get(); }
 
  private:
-  CombinedSchemaRegistry* global_registry_;
+  scoped_ptr<SchemaRegistry> registry_;

[bartfab (slow), 2014/06/20 14:48:01]

Nit: #include "base/memory/scoped_ptr.h"

[Joao da Silva, 2014/06/20 15:30:14]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(SchemaRegistryService);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_SCHEMA_REGISTRY_SERVICE_H_